Remove the private-repo install instructions - #3
Merged
Conversation
The repository is public, so qbraid.com/code.sh and /code.ps1 are the only install path anyone needs. The README still told people to authenticate with gh and fetch the contents API, and the download error blamed repository permissions for what is now an ordinary connection failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2, which merged while the repository was still private.
qBraid/qbraid-codeis public now, so three pieces of text are wrong:qbraid.com/code.sh"is not live yet" andgives a
gh api ... contents/install.sh | bashfallback that needs orgmembership. Both URLs are live and anonymous.
install.shandinstall.ps1fail a download with "While this repository isprivate you need the GitHub CLI", which now misdiagnoses an outage or a
dropped connection as a permissions problem.
The
ghfallback itself stays — it is a reasonable last resort if bothqbraid.com and raw.githubusercontent.com are unreachable — only the wording
changes.
Verified after the flip
All seven files serve anonymously from
raw.githubusercontent.com, and throughthe qbraid.com proxy (qbraid-external-site#107):
/code.sh,/code.ps1/code/{qbraid-code,statusline.sh,statusline.ps1,doctor.ps1,qbraid-code.cmd}/code/nope,..%2F..%2Fetc%2Fpasswdcurl <proxy>/code.sh | bash -s -- --helpcurl <proxy>/code.sh | bash(bad key)shellcheck -S warningandbash -nclean;tests/statusline.sh12/12.